Use _pywrap_events_writer #2683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
approved these changes
Sep 20, 2019
Contributor
wchargin
left a comment
wchargin
left a comment
There was a problem hiding this comment.
For context, this is for compatibility with an upstream commit:
tensorflow/tensorflow@5a9b155
Confirmed fixed after test sync (Googlers, see http://cl/270160498).
Thanks!
tensorflow-copybara
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 24, 2019
…nstead of swig. This is part of a larger effort to deprecate swig and eventually with modularization break pywrap_tensorflow into smaller components. It will also make exporting C++ ops to Python significantly easier. XLA is using the pybind11 macros already. Please refer to https://github.com/tensorflow/community/blob/master/rfcs/20190208-pybind11.md for more information. We are slightly changing the behavior of EventsWriter. Rather than returning a bad status when writing to a deleted file which is often ignored by the user, we are removing the FileStillExists check. TensorBoard has already been prepared for this change via: tensorflow/tensorboard#2683 PiperOrigin-RevId: 270945727
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the EventsWriter import to _pywrap_events_writer from pywrap_tensorflow.
Motivation for features / changes
This is part of a larger effort in TensorFlow to break up pywrap_tensorflow and migrate from SWIG to pybind11. Please refer to this RFC for more information.
Technical description of changes
Changes the import package to point to the new one.
Detailed steps to verify changes work correctly (as executed by you)
This is an example of a pywrap import and how it works. Unfortunately I cannot provide an exact EventsWriter example, because the nightly binary has not been built yet.
NOTE: Please only submit this PR if you are pulling TensorFlow from
tf-nightly-2.0-preview. If you are usingtf-nightly, that has not been updated since 08/21 and is still using old code.