Skip to content

Fix slicing buckets in WIT #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameswex merged 1 commit into from
Sep 28, 2019
Merged

Fix slicing buckets in WIT #2704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...tive_inference/tf_interactive_inference_dashboard/tf-interactive-inference-dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6740,12 +6740,13 @@ <h2>Show similarity to selected datapoint</h2>
calculateBucketEdges_: function(feature, numBuckets) {
if (
!this.isNumericFeature_(feature) ||
// No point in aggregating if less unique values than buckets.
this.stats[feature].uniqueCount < numBuckets ||
// No point in aggregating if not more unique values than buckets.
this.stats[feature].uniqueCount <= numBuckets ||
// Already done.
(this.featureBucketEdges_[feature] &&
this.featureBucketEdges_[feature].length == numBuckets + 1)
) {
delete this.featureBucketEdges_[feature];
return;
}
const min = this.stats[feature].numberMin;
Expand Down