Skip to content

csp: add frame-ancestors * #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 1 commit into from
Oct 18, 2019
Merged

csp: add frame-ancestors * #2797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorboard/backend/http_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ def Respond(request,
"'self'",
*_CSP_FONT_DOMAINS_WHITELIST
),
'frame-ancestors *',
# Dynamic plugins are rendered inside an iframe.
"frame-src 'self'",
# data uri used by favicon
Expand Down
10 changes: 5 additions & 5 deletions tensorboard/backend/http_util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def testCsp(self):
r = http_util.Respond(
q, '<b>hello</b>', 'text/html', csp_scripts_sha256s=['abcdefghi'])
expected_csp = (
"default-src 'self';font-src 'self';"
"default-src 'self';font-src 'self';frame-ancestors *;"
"frame-src 'self';img-src 'self' data:;object-src 'none';"
"style-src https://www.gstatic.com data: 'unsafe-inline';"
"script-src 'self' 'unsafe-eval' 'sha256-abcdefghi'"
Expand All @@ -204,7 +204,7 @@ def testCsp_noHash(self):
q = wrappers.Request(wtest.EnvironBuilder().get_environ())
r = http_util.Respond(q, '<b>hello</b>', 'text/html', csp_scripts_sha256s=None)
expected_csp = (
"default-src 'self';font-src 'self';"
"default-src 'self';font-src 'self';frame-ancestors *;"
"frame-src 'self';img-src 'self' data:;object-src 'none';"
"style-src https://www.gstatic.com data: 'unsafe-inline';"
"script-src 'none'"
Expand All @@ -216,7 +216,7 @@ def testCsp_onlySelf(self):
q = wrappers.Request(wtest.EnvironBuilder().get_environ())
r = http_util.Respond(q, '<b>hello</b>', 'text/html', csp_scripts_sha256s=None)
expected_csp = (
"default-src 'self';font-src 'self';"
"default-src 'self';font-src 'self';frame-ancestors *;"
"frame-src 'self';img-src 'self' data:;object-src 'none';"
"style-src https://www.gstatic.com data: 'unsafe-inline';"
"script-src 'self'"
Expand All @@ -229,7 +229,7 @@ def testCsp_disableUnsafeEval(self):
r = http_util.Respond(
q, '<b>hello</b>', 'text/html', csp_scripts_sha256s=['abcdefghi'])
expected_csp = (
"default-src 'self';font-src 'self';"
"default-src 'self';font-src 'self';frame-ancestors *;"
"frame-src 'self';img-src 'self' data:;object-src 'none';"
"style-src https://www.gstatic.com data: 'unsafe-inline';"
"script-src 'self' 'sha256-abcdefghi'"
Expand All @@ -244,7 +244,7 @@ def testCsp_globalDomainWhiteList(self):
q = wrappers.Request(wtest.EnvironBuilder().get_environ())
r = http_util.Respond(q, '<b>hello</b>', 'text/html', csp_scripts_sha256s=['abcd'])
expected_csp = (
"default-src 'self';font-src 'self';"
"default-src 'self';font-src 'self';frame-ancestors *;"
"frame-src 'self';img-src 'self' data: https://example.com;object-src 'none';"
"style-src https://www.gstatic.com data: 'unsafe-inline' https://googol.com;"
"script-src https://tensorflow.org/tensorboard 'self' 'unsafe-eval' "
Expand Down