program: don’t set default flags on base parser #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT SUBMIT Will write description and test plan later… got to go… opening PR now to start CI. :-) wchargin-branch: program-defaults
nfelt
approved these changes
Oct 21, 2019
|
|
||
| with argparse_util.allow_missing_subcommand(): | ||
| flags = base_parser.parse_args(argv[1:]) # Strip binary name from argv. | ||
| if getattr(flags, _SUBCOMMAND_FLAG, None) is None: |
Contributor
There was a problem hiding this comment.
Maybe worth adding a TODO/note here so we can revert after we drop support for old python?
wchargin-branch: program-defaults wchargin-source: 8503cff78bd97157a3714758a65947d766c5b18e
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary:
With old versions of `argparse`, any `set_defaults` on the base parser
will take precedence over any `set_defaults` on the subparsers. This is
Python [bug #9351][bpo-9351], fixed in [af26c15110b7][fix]. Even though
the versions of argparse bundled with Python 2.7 and 3.5 each include
the fix, we can still avoid this pattern for compatibility.
To see if your Python is affected, run:
```python
import argparse
parser = argparse.ArgumentParser()
parser.set_defaults(test="AFFECTED")
parser.add_subparsers().add_parser("sub").set_defaults(test="OK")
print(parser.parse_args(["sub"]).test)
```
If it prints `AFFECTED`, then this patch affects your Python.
Googlers, see <http://b/143087149> for context.
[bpo-9351]: https://bugs.python.org/issue9351
[fix]: http://github.com/python/cpython/commit/af26c15110b76195e62a06d17e39176d42c0511c
Test Plan:
Running under an old version of `argparse`, existing tests fail before
this change and pass after.
wchargin-branch: program-defaults
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary:
With old versions of `argparse`, any `set_defaults` on the base parser
will take precedence over any `set_defaults` on the subparsers. This is
Python [bug #9351][bpo-9351], fixed in [af26c15110b7][fix]. Even though
the versions of argparse bundled with Python 2.7 and 3.5 each include
the fix, we can still avoid this pattern for compatibility.
To see if your Python is affected, run:
```python
import argparse
parser = argparse.ArgumentParser()
parser.set_defaults(test="AFFECTED")
parser.add_subparsers().add_parser("sub").set_defaults(test="OK")
print(parser.parse_args(["sub"]).test)
```
If it prints `AFFECTED`, then this patch affects your Python.
Googlers, see <http://b/143087149> for context.
[bpo-9351]: https://bugs.python.org/issue9351
[fix]: http://github.com/python/cpython/commit/af26c15110b76195e62a06d17e39176d42c0511c
Test Plan:
Running under an old version of `argparse`, existing tests fail before
this change and pass after.
wchargin-branch: program-defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With old versions of
argparse, anyset_defaultson the base parserwill take precedence over any
set_defaultson the subparsers. This isPython bug #9351, fixed in af26c15110b7. Even though
the versions of argparse bundled with Python 2.7 and 3.5 each include
the fix, we can still avoid this pattern for compatibility.
To see if your Python is affected, run:
If it prints
AFFECTED, then this patch affects your Python.Googlers, see http://b/143087149 for context.
Test Plan:
Running under an old version of
argparse, existing tests fail beforethis change and pass after.
wchargin-branch: program-defaults