proto: support build deps #2809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: By happenstance, none of our existing proto definitions need build-level dependencies (dependencies on proto files from other build targets). But this is no fundamental restriction. We teach `tb_proto_library` a `deps` argument, pointing to other targets generated by `tb_proto_library`. Test Plan: Unit tests added. After building the Pip package and installing it into a new virtualenv, we can still use `tensorboard.compat.proto` modules. wchargin-branch: proto-deps
stephanwlee
approved these changes
Oct 21, 2019
Contributor
stephanwlee
left a comment
stephanwlee
left a comment
There was a problem hiding this comment.
Tests look good but I kinda wish the test_*.proto appeared inside tensorboard/defs/test directory.
Contributor
Author
No such directory yet exists, and given that the tests are for a file in It’s |
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: By happenstance, none of our existing proto definitions need build-level dependencies (dependencies on proto files from other build targets). But this is no fundamental restriction. We teach `tb_proto_library` a `deps` argument, pointing to other `tb_proto_library` macro invocations. Test Plan: Unit tests added. After building the Pip package and installing it into a new virtualenv, we can still use `tensorboard.compat.proto` modules. wchargin-branch: proto-deps
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: By happenstance, none of our existing proto definitions need build-level dependencies (dependencies on proto files from other build targets). But this is no fundamental restriction. We teach `tb_proto_library` a `deps` argument, pointing to other `tb_proto_library` macro invocations. Test Plan: Unit tests added. After building the Pip package and installing it into a new virtualenv, we can still use `tensorboard.compat.proto` modules. wchargin-branch: proto-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
By happenstance, none of our existing proto definitions need build-level
dependencies (dependencies on proto files from other build targets). But
this is no fundamental restriction. We teach
tb_proto_libraryadepsargument, pointing to other
tb_proto_librarymacro invocations.Test Plan:
Unit tests added. After building the Pip package and installing it into
a new virtualenv, we can still use
tensorboard.compat.protomodules.wchargin-branch: proto-deps