util: add grpc_util with backoff helper
#2810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit adds `tensorboard.util.grpc_util`, which provides methods for consumers of gRPC services. Original implementation due to @nfelt. Test Plan: Unit tests included. They require that the `grpcio` Pip distribution (which provides the `grpc` Python package) be installed in the enclosing virtualenv. This is already a dependency of `tensorboard`, so on typical setups no additional action should be required. Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> wchargin-branch: grpc-util
wchargin
commented
Oct 22, 2019
wchargin-branch: grpc-util wchargin-source: dee9ce6f75eb8c3b5bb7f7d87cb5962e1ac83139
nfelt
approved these changes
Oct 22, 2019
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Gosh, it's a pity that we had to strip out all those lovely PyType annotations, but at least we had them for a whole month! /s
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: This commit adds `tensorboard.util.grpc_util`, which provides methods for consumers of gRPC services. Original implementation due to @nfelt. Test Plan: Unit tests included. They require that the `grpcio` Pip distribution (which provides the `grpc` Python package) be installed in the enclosing virtualenv. This is already a dependency of `tensorboard`, so on typical setups no additional action should be required. Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> wchargin-branch: grpc-util
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: This commit adds `tensorboard.util.grpc_util`, which provides methods for consumers of gRPC services. Original implementation due to @nfelt. Test Plan: Unit tests included. They require that the `grpcio` Pip distribution (which provides the `grpc` Python package) be installed in the enclosing virtualenv. This is already a dependency of `tensorboard`, so on typical setups no additional action should be required. Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> wchargin-branch: grpc-util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds
tensorboard.util.grpc_util, which provides methodsfor consumers of gRPC services.
Original implementation due to @nfelt.
Test Plan:
Unit tests included. They require that the
grpcioPip distribution(which provides the
grpcPython package) be installed in the enclosingvirtualenv. This is already a dependency of
tensorboard, so on typicalsetups no additional action should be required.
Co-authored-by: Nick Felt nfelt@users.noreply.github.com
wchargin-branch: grpc-util