Add uploader gRPC client #2822
Merged
Add uploader gRPC client #2822
+3,722
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit includes a gRPC client for a hosted TensorBoard service, which is accessible as a new subcommand under the main `tensorboard` binary. Test Plan: Modify `dev_creds.py` to include credentials, then build the Pip package (`bazel run //tensorboard/pip_package:extract_pip_package`) and install it into a new virtualenv. Run ``` tensorboard dev --endpoint ENDPOINT upload --logdir ~/tensorboard_data/mnist ``` where `ENDPOINT` is a running API server (like `localhost:12345`), and verify that the upload succeeds. Then verify that normal `tensorboard` still works to serve locally. Co-authored-by: ericdnielsen <ericdnielsen@gmail.com> Co-authored-by: Karthik Ramasamy <karthikv2k@gmail.com> Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> Co-authored-by: Stanley Bileschi <bileschi@google.com> Co-authored-by: William Chargin <wchargin@gmail.com>
nfelt
approved these changes
Oct 24, 2019
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Please split into smaller PRs for ease of reviewing. I'd say maybe about 20? Should keep our Travis VMs nice and warm for a couple weeks.
jk jk lol 🥝
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: This commit includes a gRPC client for a hosted TensorBoard service, which is accessible as a new subcommand under the main `tensorboard` binary. Test Plan: Modify `dev_creds.py` to include credentials, then build the Pip package (`bazel run //tensorboard/pip_package:extract_pip_package`) and install it into a new virtualenv. Run ``` tensorboard dev --endpoint ENDPOINT upload --logdir ~/tensorboard_data/mnist ``` where `ENDPOINT` is a running API server (like `localhost:12345`), and verify that the upload succeeds. Then verify that normal `tensorboard` still works to serve locally. Co-authored-by: ericdnielsen <ericdnielsen@gmail.com> Co-authored-by: Karthik Ramasamy <karthikv2k@gmail.com> Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> Co-authored-by: Stanley Bileschi <bileschi@google.com> Co-authored-by: William Chargin <wchargin@gmail.com>
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: This commit includes a gRPC client for a hosted TensorBoard service, which is accessible as a new subcommand under the main `tensorboard` binary. Test Plan: Modify `dev_creds.py` to include credentials, then build the Pip package (`bazel run //tensorboard/pip_package:extract_pip_package`) and install it into a new virtualenv. Run ``` tensorboard dev --endpoint ENDPOINT upload --logdir ~/tensorboard_data/mnist ``` where `ENDPOINT` is a running API server (like `localhost:12345`), and verify that the upload succeeds. Then verify that normal `tensorboard` still works to serve locally. Co-authored-by: ericdnielsen <ericdnielsen@gmail.com> Co-authored-by: Karthik Ramasamy <karthikv2k@gmail.com> Co-authored-by: Nick Felt <nfelt@users.noreply.github.com> Co-authored-by: Stanley Bileschi <bileschi@google.com> Co-authored-by: William Chargin <wchargin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit includes a gRPC client for a hosted TensorBoard service,
which is accessible as a new subcommand under the main
tensorboardbinary.
Test Plan:
Modify
dev_creds.pyto include credentials, then build the Pip package(
bazel run //tensorboard/pip_package:extract_pip_package) and installit into a new virtualenv. Run
where
ENDPOINTis a running API server (likelocalhost:12345), andverify that the upload succeeds. Then verify that normal
tensorboardstill works to serve locally.
Co-authored-by: ericdnielsen ericdnielsen@gmail.com
Co-authored-by: Karthik Ramasamy karthikv2k@gmail.com
Co-authored-by: Nick Felt nfelt@users.noreply.github.com
Co-authored-by: Stanley Bileschi bileschi@google.com
Co-authored-by: William Chargin wchargin@gmail.com