Bump grpcio version to 1.24.3
#2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We depend on `grpc.local_server_credentials`, which was added in 1.24.0. Installing the Pip package into a fresh virtualenv generally picks this up, because the `grpcio >= 1.6.3` will install the latest version, but that won’t suffice for virtualenvs that already have an old version installed. We now explicitly depend on `1.24.3`. Travis wasn’t seeing this problem because the `grpcio-testing` dep pulls in a matching version of `grpcio`. Test Plan: None. wchargin-branch: grpcio-1.24.3
nfelt
approved these changes
Oct 24, 2019
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: We depend on `grpc.local_server_credentials`, which was added in 1.24.0. Installing the Pip package into a fresh virtualenv generally picks this up, because the `grpcio >= 1.6.3` will install the latest version, but that won’t suffice for virtualenvs that already have an old version installed. We now explicitly depend on `1.24.3`. Travis wasn’t seeing this problem because the `grpcio-testing` dep pulls in a matching version of `grpcio`. Test Plan: Create a new virtualenv and install `grpcio==1.16.0` (e.g.) into it. Then, install the TensorBoard Pip package. Run ``` python -c 'import grpc; print(grpc.local_server_credentials)' ``` and note that this now passes instead of failing with `AttributeError`. wchargin-branch: grpcio-1.24.3
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: We depend on `grpc.local_server_credentials`, which was added in 1.24.0. Installing the Pip package into a fresh virtualenv generally picks this up, because the `grpcio >= 1.6.3` will install the latest version, but that won’t suffice for virtualenvs that already have an old version installed. We now explicitly depend on `1.24.3`. Travis wasn’t seeing this problem because the `grpcio-testing` dep pulls in a matching version of `grpcio`. Test Plan: Create a new virtualenv and install `grpcio==1.16.0` (e.g.) into it. Then, install the TensorBoard Pip package. Run ``` python -c 'import grpc; print(grpc.local_server_credentials)' ``` and note that this now passes instead of failing with `AttributeError`. wchargin-branch: grpcio-1.24.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We depend on
grpc.local_server_credentials, which was added in 1.24.0.Installing the Pip package into a fresh virtualenv generally picks this
up, because the
grpcio >= 1.6.3will install the latest version, butthat won’t suffice for virtualenvs that already have an old version
installed. We now explicitly depend on
1.24.3.Travis wasn’t seeing this problem because the
grpcio-testingdep pullsin a matching version of
grpcio.Test Plan:
Create a new virtualenv and install
grpcio==1.16.0(e.g.) into it.Then, install the TensorBoard Pip package. Run
and note that this now passes instead of failing with
AttributeError.wchargin-branch: grpcio-1.24.3