Configure oauth for uploader client and make it required #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/LGTM |
wchargin
approved these changes
Oct 25, 2019
wchargin
pushed a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
…2836) * Remove --auth_type argument and make use of OAuth creds unconditional * Add OAuth client configuration
Merged
wchargin
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Remove --auth_type argument and make use of OAuth creds unconditional * Add OAuth client configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
--auth_typeargument that doesn't work anyway to avoid confusion, and adds an OAuth client configuration.Tested locally.
See internal b/143329558.