uploader: fix export when outdir has no slash #2847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
When given `tensorboard dev export --outdir "${path}"`, we run the
Python equivalent of `mkdir -p "$(dirname "${path}")"`. But this fails
when `"$(dirname "${path}")"` is empty, which occurs when `path` has no
directory separator.
Test Plan:
Unit test added: it fails before this change and passes after it.
wchargin-branch: export-no-slash
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary:
Given `export --outdir "${path}"`, we run `makedirs(dirname(path))`. But
this fails when `dirname(path)` is empty, which occurs when `path` has
no directory separator.
Test Plan:
Unit test added: it fails before this change and passes after it.
wchargin-branch: export-no-slash
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary:
Given `export --outdir "${path}"`, we run `makedirs(dirname(path))`. But
this fails when `dirname(path)` is empty, which occurs when `path` has
no directory separator.
Test Plan:
Unit test added: it fails before this change and passes after it.
wchargin-branch: export-no-slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Given
export --outdir "${path}", we runmakedirs(dirname(path)). Butthis fails when
dirname(path)is empty, which occurs whenpathhasno directory separator.
Test Plan:
Unit test added: it fails before this change and passes after it.
wchargin-branch: export-no-slash