uploader: change request batch size to 128 KiB #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Typical requests now include ~4700 scalars instead of ~37000 scalars (and are correspondingly processed faster by the server). This is now reliably hitting the client-side rate limiting, so we’re sending one request per 5 seconds. Test Plan: The following patch is useful for testing: ```diff diff --git a/tensorboard/uploader/uploader.py b/tensorboard/uploader/uploader.py index 1a6e795..c3191746 100644 --- a/tensorboard/uploader/uploader.py +++ b/tensorboard/uploader/uploader.py @@ -130,6 +130,10 @@ class TensorBoardUploader(object): request_bytes = request.ByteSize() - logger.info("Trying request of %d bytes", request_bytes) + total_scalars = sum( + len(tag.points) for run in request.runs for tag in run.tags) + logger.warning( + "Trying request of %d bytes (%d scalars)", + request_bytes, total_scalars) self._upload(request) upload_duration_secs = time.time() - upload_start_time - logger.info( + logger.warning( "Upload for %d runs (%d bytes) took %.3f seconds", ``` wchargin-branch: uploader-batch-128kib
Contributor
|
Thanks for the change! |
karthikv2k
approved these changes
Oct 28, 2019
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: Typical requests now include ~4700 scalars instead of ~37000 scalars (and are correspondingly processed faster by the server). This is now reliably hitting the client-side rate limiting, so we’re sending one request per 5 seconds. Test Plan: The following patch is useful for testing: ```diff diff --git a/tensorboard/uploader/uploader.py b/tensorboard/uploader/uploader.py index 1a6e795..c3191746 100644 --- a/tensorboard/uploader/uploader.py +++ b/tensorboard/uploader/uploader.py @@ -130,6 +130,10 @@ class TensorBoardUploader(object): request_bytes = request.ByteSize() - logger.info("Trying request of %d bytes", request_bytes) + total_scalars = sum( + len(tag.points) for run in request.runs for tag in run.tags) + logger.warning( + "Trying request of %d bytes (%d scalars)", + request_bytes, total_scalars) self._upload(request) upload_duration_secs = time.time() - upload_start_time - logger.info( + logger.warning( "Upload for %d runs (%d bytes) took %.3f seconds", ``` wchargin-branch: uploader-batch-128kib
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: Typical requests now include ~4700 scalars instead of ~37000 scalars (and are correspondingly processed faster by the server). This is now reliably hitting the client-side rate limiting, so we’re sending one request per 5 seconds. Test Plan: The following patch is useful for testing: ```diff diff --git a/tensorboard/uploader/uploader.py b/tensorboard/uploader/uploader.py index 1a6e795..c3191746 100644 --- a/tensorboard/uploader/uploader.py +++ b/tensorboard/uploader/uploader.py @@ -130,6 +130,10 @@ class TensorBoardUploader(object): request_bytes = request.ByteSize() - logger.info("Trying request of %d bytes", request_bytes) + total_scalars = sum( + len(tag.points) for run in request.runs for tag in run.tags) + logger.warning( + "Trying request of %d bytes (%d scalars)", + request_bytes, total_scalars) self._upload(request) upload_duration_secs = time.time() - upload_start_time - logger.info( + logger.warning( "Upload for %d runs (%d bytes) took %.3f seconds", ``` wchargin-branch: uploader-batch-128kib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Typical requests now include ~4700 scalars instead of ~37000 scalars
(and are correspondingly processed faster by the server). This is now
reliably hitting the client-side rate limiting, so we’re sending one
request per 5 seconds.
Test Plan:
The following patch is useful for testing:
wchargin-branch: uploader-batch-128kib