uploader: add TensorBoard.dev branding #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This includes the Terms of Service link in the consent screen, as well as the explicit disclaimer that all uploaded data is publicly visible. It also patches the help text (`tensorboard -h`, `tensorboard dev -h`). Test Plan: Running `git grep "a hosted"` (…service) no longer returns any results. wchargin-branch: tensorboard.dev
manivaradarajan
approved these changes
Oct 28, 2019
nfelt
approved these changes
Oct 28, 2019
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
LGTM, though not sure it's necessary to change the proto files, since they're pretty agnostic to the specific service and in theory could be shared across services.
GalOshri
approved these changes
Oct 28, 2019
Contributor
GalOshri
left a comment
GalOshri
left a comment
There was a problem hiding this comment.
LGTM, just need to add the ".html" to the terms URL.
wchargin-branch: tensorboard.dev wchargin-source: cbfbad64a3d783250e403f055c7a7c1501eea0b6
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Summary: This includes the Terms of Service link in the consent screen, as well as the explicit disclaimer that all uploaded data is publicly visible. It also patches the help text (`tensorboard -h`, `tensorboard dev -h`). Test Plan: Running `git grep "a hosted"` (…service) no longer returns any results. wchargin-branch: tensorboard.dev
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Summary: This includes the Terms of Service link in the consent screen, as well as the explicit disclaimer that all uploaded data is publicly visible. It also patches the help text (`tensorboard -h`, `tensorboard dev -h`). Test Plan: Running `git grep "a hosted"` (…service) no longer returns any results. wchargin-branch: tensorboard.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This includes the Terms of Service link in the consent screen, as well
as the explicit disclaimer that all uploaded data is publicly visible.
It also patches the help text (
tensorboard -h,tensorboard dev -h).Test Plan:
Running
git grep "a hosted"(…service) no longer returns any results.wchargin-branch: tensorboard.dev