Improve error handling for exporting large experiments #2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oader. Tested: Adds unit tests for grpc.CANCELLED case.
wchargin
reviewed
Oct 28, 2019
Contributor
|
Thanks! By convention, commit headlines are imperative (as with internal |
bileschi
changed the title
wchargin
approved these changes
Oct 29, 2019
| del request # unused | ||
| yield export_service_pb2.StreamExperimentsResponse( | ||
| experiment_ids=[experiment_id]) | ||
| experiment_ids = [experiment_id]) |
Contributor
There was a problem hiding this comment.
nit: No spaces around kwargs. The full whitespace rules are here:
https://google.github.io/styleguide/pyguide.html#36-whitespace
wchargin
pushed a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Improves error handling for exporting large experiments using the uploader. Tested: Adds unit tests for grpc.CANCELLED case.
Merged
wchargin
pushed a commit
that referenced
this pull request
Oct 29, 2019
Improves error handling for exporting large experiments using the uploader. Tested: Adds unit tests for grpc.CANCELLED case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large experiments sometimes fail to export due to grpc timeouts. This change clarifies the situation to the user.
Tested:
Adds unit tests for grpc.CANCELLED case.