Skip to content

Conversation

@bileschi
Copy link
Collaborator

Export service definition has changed slightly in that all scalars for a given tag are not necessarily all in the same response. This is to support tags that are too big, for one reason or another, to fit into a single response.

This change updates the comment to reflect the change in understanding.

// result only contains data for a single tag from a single run. For example if
// there are five runs and each run had two tags, the RPC will return a stream
// of at least ten `StreamExperimentDataResponse`s, each one having the
// scalars for one tag. The values from a single tag may be spit among multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/spit/split/

// there are five runs and each run had two tags, the RPC will return a stream
// of at least ten `StreamExperimentDataResponse`s, each one having the
// scalars for one tag. The values from a single tag may be spit among multiple
// scalars for one tag. The values from a single tag may be slpit among multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/slpit/split/ :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Fixed for you to get CI started.)

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@wchargin
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bileschi bileschi merged commit 1436640 into master Oct 29, 2019
@bileschi bileschi deleted the bileschi-export-proto-comment branch October 29, 2019 17:00
wchargin pushed a commit to wchargin/tensorboard that referenced this pull request Oct 29, 2019
Fixes a description of a service response, given a slight change in semantics.
@wchargin wchargin mentioned this pull request Oct 29, 2019
wchargin pushed a commit that referenced this pull request Oct 29, 2019
Fixes a description of a service response, given a slight change in semantics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants