-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix comment in export.proto #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // result only contains data for a single tag from a single run. For example if | ||
| // there are five runs and each run had two tags, the RPC will return a stream | ||
| // of at least ten `StreamExperimentDataResponse`s, each one having the | ||
| // scalars for one tag. The values from a single tag may be spit among multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/spit/split/
| // there are five runs and each run had two tags, the RPC will return a stream | ||
| // of at least ten `StreamExperimentDataResponse`s, each one having the | ||
| // scalars for one tag. The values from a single tag may be spit among multiple | ||
| // scalars for one tag. The values from a single tag may be slpit among multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/slpit/split/ :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Fixed for you to get CI started.)
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fixes a description of a service response, given a slight change in semantics.
Fixes a description of a service response, given a slight change in semantics.
Export service definition has changed slightly in that all scalars for a given tag are not necessarily all in the same response. This is to support tags that are too big, for one reason or another, to fit into a single response.
This change updates the comment to reflect the change in understanding.