uploader: set default endpoint to production #2856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: Build the Pip package and install it into a new virtualenv. Using the new package, revoke auth (`tensorboard dev auth revoke`), then upload an experiment. Note that the correct Terms of Service and Privacy Policy documents are clearly displayed in the consent prompt. wchargin-branch: uploader-prod
stephanwlee
approved these changes
Oct 29, 2019
nfelt
approved these changes
Oct 29, 2019
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Oct 29, 2019
Test Plan: Build the Pip package and install it into a new virtualenv. Using the new package, revoke auth (`tensorboard dev auth revoke`), then upload an experiment. Note that the correct Terms of Service and Privacy Policy documents are clearly displayed in the consent prompt. wchargin-branch: uploader-prod
Merged
wchargin
added a commit
that referenced
this pull request
Oct 29, 2019
Test Plan: Build the Pip package and install it into a new virtualenv. Using the new package, revoke auth (`tensorboard dev auth revoke`), then upload an experiment. Note that the correct Terms of Service and Privacy Policy documents are clearly displayed in the consent prompt. wchargin-branch: uploader-prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Build the Pip package and install it into a new virtualenv. Using the
new package, revoke auth (
tensorboard dev auth revoke), then upload anexperiment. Note that the correct Terms of Service and Privacy Policy
documents are clearly displayed in the consent prompt.
wchargin-branch: uploader-prod