Remove unused deps blocking sync #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
approved these changes
Nov 8, 2019
stephanwlee
approved these changes
Nov 8, 2019
| "//tensorboard/webapp/angular:expect_angular_material_input", | ||
| "//tensorboard/webapp/core", | ||
| "//tensorboard/webapp/core/store", | ||
| "//tensorboard/webapp/core/actions", |
Contributor
There was a problem hiding this comment.
some buildifier on these files would be nice (I used it before so it is kosher here; this file requires alphasorting).
Member
Author
There was a problem hiding this comment.
I'd really like to get buildifier working externally as a matter of course (i.e., even in our CI). Let's punt this until then.
psybuzz
approved these changes
Nov 8, 2019
Contributor
psybuzz
left a comment
psybuzz
left a comment
There was a problem hiding this comment.
Thanks for this cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two copypasta dependencies broke our internal sync.
Also, internally we enforce strict deps, so I added a bunch that were transitive before.
There are probably more unused deps that we can clean up later, but that are not blocking as far as I know.