Skip to content

Relax minimum version of requests to allow 2.21.0 #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfelt merged 1 commit into from
Nov 9, 2019
Merged

Relax minimum version of requests to allow 2.21.0 #2914

nfelt merged 1 commit into from
Nov 9, 2019

Conversation

@nfelt
Copy link
Contributor

@nfelt nfelt commented Nov 9, 2019 •
edited
Loading

Confirmed that server_info_test still passes with requests==2.21.0.

@nfelt nfelt requested a review from wchargin November 9, 2019 01:26
@nfelt nfelt merged commit e15f1b9 into tensorflow:master Nov 9, 2019
@nfelt nfelt deleted the requests-downgrade branch November 9, 2019 03:20
@wchargin
Copy link
Contributor

wchargin commented Nov 10, 2019

For posterity: The latest version of requests that supports Python 3.4
is 2.21.0. While we don’t officially support Python 3.4, we also don’t
need any of the functionality introduced specifically in 2.22.0, so it
doesn’t hurt us to relax the dependency bound.

wchargin pushed a commit to wchargin/tensorboard that referenced this pull request Nov 25, 2019
@nfelt @wchargin
Relax minimum version of requests to allow 2.21.0 (tensorflow#2914)
a5f5d46
@wchargin wchargin mentioned this pull request Nov 25, 2019
Merged
wchargin pushed a commit that referenced this pull request Nov 25, 2019
@nfelt @wchargin
Relax minimum version of requests to allow 2.21.0 (#2914)
c3fc715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wchargin wchargin wchargin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nfelt @wchargin @googlebot