build: deprecate shasum in Vulcanization #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Cancelled build to unblock #2947, without which this build would fail |
stephanwlee
force-pushed
the
vulc-clean
branch
4 times, most recently
from
24aeac5 to
388d147
Compare
nfelt
approved these changes
Nov 21, 2019
stephanwlee
force-pushed
the
vulc-clean
branch
from
486ac28 to
82a79e6
Compare
wchargin
approved these changes
Nov 22, 2019
As part of our security hardening and CSP support, we decided to introduce script checksum as part of the Vulcanization that gets used at the serving time using http_util.py. We understand that this imposes a bit too stringent requirements for all and we decided to relax the CSP comformance a little by trusting JavaScript from our server (effectively, default-src 'self'). Note that we do not yet remove shasum related code from http_util because it is being used by the Plugin HTML endpoint in application.py. For that, we may want to use nonce or separate JavaScript file approach.
stephanwlee
force-pushed
the
vulc-clean
branch
from
28eff55 to
6fec68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our security hardening and CSP support, we decided to
introduce script checksum as part of the Vulcanization that gets used at
the serving time using http_util.py. We understand that this imposes
a bit too stringent requirements for all and we decided to relax the CSP
comformance a little by trusting JavaScript from our server
(effectively, default-src 'self').
Note that we do not yet remove shasum related code from http_util
because it is being used by the Plugin HTML endpoint in application.py.
For that, we may want to use nonce or separate JavaScript file approach.