ui: add slot for injecting header items #2952
Conversation
|
Cancelled build to unblock #2947, without which this build would fail |
| }); | ||
|
|
||
| it('reloads the active dashboard on request', (done) => { | ||
| xit('reloads the active dashboard on request', (done) => { |
There was a problem hiding this comment.
prefer to accompany skipped tests with a reason.
There was a problem hiding this comment.
I've added a comment
There was a problem hiding this comment.
xdescribe, too. if you think they are stale, maybe just omit.
There was a problem hiding this comment.
Done - added to xdescribe
| checkSlottedUnderAncestor(headerItem1, '.header'); | ||
| checkSlottedUnderAncestor(headerItem2, '.header'); | ||
|
|
||
| function checkSlottedUnderAncestor( |
There was a problem hiding this comment.
several higher level comments:
- hoist this up function since it is general utility.
Polymer.dom($0).deepContains($1)may want to look into this.- consider moving new additions in tf_util to testing.ts or tf_util/shadow_dom.ts since we probably want some common utilities for ShadowDom that are missing from
Polymer.dom.
There was a problem hiding this comment.
- Done
- Thanks, I didn't know Polymer offered this!
- I'll keep in mind for the future. Polymer's
deepContains()addresses the need here, but I imagine we might want our own Shadow utils in the future
|
|
||
| describe('top right global icons', function() { | ||
| // TODO(psybuzz): Restore or remove these tests. This folder's tests seems | ||
| // to have not been running since the GitHub repo history was tracked. |
There was a problem hiding this comment.
nit: instead of describing the history, for TODOs at least, describe precondition that can resolve this TODO.
There was a problem hiding this comment.
Rewritten to note that the test was not running, and at least 1 reason for their failure.
4 participants
Motivation for features / changes
Add the ability for embedders to inject items in the header, next to the 'Reload', 'Settings' buttons.
Technical description of changes