Fix graph plugin with data provider, and its test #3001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Gah sorry something is still broken. Investigating. |
Member
Author
|
Ok, this works now. (Pretty sure the console error is a red herring, btw: that happens regardless, even with generic_data=false) |
wchargin
approved these changes
Dec 6, 2019
Contributor
wchargin
left a comment
wchargin
left a comment
There was a problem hiding this comment.
Looks good to me: in a directory with run-level graphs, graphs in
summaries, and profiling graphs, this displays only the run-level graphs
and displays them correctly.
davidsoergel
force-pushed
the
fix-graph-plugin-data-provider
branch
from
1cd9a88 to
5a944ce
Compare
wchargin
added a commit
that referenced
this pull request
Feb 28, 2020
Summary: Recent refactorings to the RPC rate limiting had the unintended side effect of removing rate limiting on logdir polling. This meant that after all data had been read from the logdir, the uploader would continue to poll it aggressively (thousands of times per second on my machine), which is bad for disks and expensive on network file systems. This commit adds a separate rate limiter for the logdir polling. We don’t reuse the RPC rate limiter because that would force us to tick twice on the same timer every cycle. Fixes #3001. Test Plan: Run `bazel run //tensorboard -- dev upload --logdir /nope --verbosity 0` (with any logdir path, but it’s easier when it’s empty), and note that the “Starting an upload cycle” logs now progress at 0.2 per second rather than 6000 per second. TODO: Unit tests. wchargin-branch: uploader-rate-limit-polling wchargin-source: 2036f1c749e0c2f4e6db2362257e1f3f3a4342f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in #2991 found by @wchargin.
More importantly, it fixes the test that should have caught that bug in the first place (which has been broken since #1853): expected and actual data were being compared with
assertItemsEqualinstead ofassertEqual, and so differences were not detected.