ci: remove Python 2.7 from .travis.yml
#3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A new year, a new dawn. The <https://pythonclock.org/> has expired, and TensorFlow has dropped Python 2 support: <https://groups.google.com/a/tensorflow.org/d/msg/developers/ifEAGK3aPls/jlEuWYObBgAJ> As noted in the above announcement, TensorFlow 2.1.0 will be released with Python 2.7 support, but we’ve already released the corresponding TensorBoard 2.1.0, so we no longer need to test with Python 2 at head. Test Plan: That CI passes quickly suffices. wchargin-branch: travis-nopy2
Contributor
|
I'm approving this PR based on the following considerations:
There might be other constraints that require tensorboard to be python2-compatible for a certain period of time (e.g., 1 year) from now. If such constraints become apparent, we can revisit this. |
Contributor
Author
|
Agreed, and note also that the |
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 2, 2020
Summary: A new year, a new dawn. The <https://pythonclock.org/> has expired, and TensorFlow has dropped Python 2 support: <https://groups.google.com/a/tensorflow.org/d/msg/developers/ifEAGK3aPls/jlEuWYObBgAJ> As noted in the above announcement, TensorFlow 2.1.0 will be released with Python 2.7 support, but we’ve already released the corresponding TensorBoard 2.1.0, so we no longer need to test with Python 2 at head. Test Plan: That CI passes quickly suffices. wchargin-branch: travis-nopy2
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
Summary: A new year, a new dawn. The <https://pythonclock.org/> has expired, and TensorFlow has dropped Python 2 support: <https://groups.google.com/a/tensorflow.org/d/msg/developers/ifEAGK3aPls/jlEuWYObBgAJ> As noted in the above announcement, TensorFlow 2.1.0 will be released with Python 2.7 support, but we’ve already released the corresponding TensorBoard 2.1.0, so we no longer need to test with Python 2 at head. Test Plan: That CI passes quickly suffices. wchargin-branch: travis-nopy2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A new year, a new dawn. The https://pythonclock.org/ has expired, and
TensorFlow has dropped Python 2 support:
https://groups.google.com/a/tensorflow.org/d/msg/developers/ifEAGK3aPls/jlEuWYObBgAJ
As noted in the above announcement, TensorFlow 2.1.0 will be released
with Python 2.7 support, but we’ve already released the corresponding
TensorBoard 2.1.0, so we no longer need to test with Python 2 at head.
Test Plan:
That CI passes quickly suffices.
wchargin-branch: travis-nopy2