When available, use inspect.getfullargspec instead of inspect.getargspec. #3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspect.getargspec. The former is only available in Python3, in which getargspec was deprecated. This allows to get rid of a deprecation warning. Both return a namedtuple with an equivalent "args" attribute, so the functionality is unchanged.
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
…pec. (tensorflow#3116) * When available, use inspect.getfullargspec instead of inspect.getargspec. The former is only available in Python3, in which getargspec was deprecated. This allows to get rid of a deprecation warning. Both return a namedtuple with an equivalent "args" attribute, so the functionality is unchanged. * Changes so that black --check succeeds.
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
…pec. (#3116) * When available, use inspect.getfullargspec instead of inspect.getargspec. The former is only available in Python3, in which getargspec was deprecated. This allows to get rid of a deprecation warning. Both return a namedtuple with an equivalent "args" attribute, so the functionality is unchanged. * Changes so that black --check succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is only available in Python3, in which getargspec was
deprecated.
Motivation for features / changes
This allows to get rid of a deprecation warning when using Python3.
Technical description of changes
Uses a Python3 drop-in replacement, when available.
Both return a namedtuple with an equivalent "args" attribute, so the
functionality is unchanged.
Screenshots of UI changes
N/A
Detailed steps to verify changes work correctly (as executed by you)
Ran event_file_loader_test, in Python2 and Python3.
Alternate designs / implementations considered