Skip to content

uploader: make util_test py3-compatible internally #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchargin merged 1 commit into from
Jan 28, 2020
Merged

uploader: make util_test py3-compatible internally #3179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tensorboard/uploader/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import datetime
import os
import time
import unittest
import mock

Expand Down Expand Up @@ -208,9 +209,13 @@ class FormatTimeTest(tb_test.TestCase):
def _run(self, t=None, now=None):
timestamp_pb = timestamp_pb2.Timestamp()
util.set_timestamp(timestamp_pb, t)
with mock.patch.dict(os.environ, {"TZ": "UTC"}):
now = datetime.datetime.fromtimestamp(now)
return util.format_time(timestamp_pb, now=now)
try:
with mock.patch.dict(os.environ, {"TZ": "UTC"}):
time.tzset()
now = datetime.datetime.fromtimestamp(now)
return util.format_time(timestamp_pb, now=now)
finally:
time.tzset()

def test_just_now(self):
base = 1546398245
Expand Down