Skip to content

cleanup: fix import statement #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephanwlee merged 2 commits into from
Feb 7, 2020
Merged

cleanup: fix import statement #3225

stephanwlee merged 2 commits into from
Feb 7, 2020

Conversation

@stephanwlee
Copy link
Contributor

@stephanwlee stephanwlee commented Feb 7, 2020 •
edited
Loading

This unblocks the sync which failed because of the strict_deps violation.

  • tensorboard/webapp/webapp_data_source/tb_server_data_source_module.ts had extraneous import statement.
  • tb_http_client_testing.ts had missing import on BUILD.

@stephanwlee stephanwlee requested a review from psybuzz February 7, 2020 00:30
@stephanwlee stephanwlee changed the title cleanup: remove extraneous import statement cleanup: fix import statement Feb 7, 2020
psybuzz
psybuzz approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@psybuzz psybuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanwlee stephanwlee merged commit 38a326b into tensorflow:master Feb 7, 2020
@stephanwlee stephanwlee deleted the bad branch February 7, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psybuzz psybuzz psybuzz approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanwlee @psybuzz @googlebot