Add the WriteBlob bidirectional streaming RPC to the write service. #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
reviewed
Feb 7, 2020
nfelt
reviewed
Feb 11, 2020
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Overall looking good (thanks for the extensive protocol documentation!) - left some comments, feel free to let me know if this was already covered in previous conversations in design review / with @wchargin that I'm lacking context on.
davidsoergel
commented
Feb 13, 2020
Member
Author
davidsoergel
left a comment
davidsoergel
left a comment
There was a problem hiding this comment.
Thanks for the excellent comments! Made some changes; PTAL.
davidsoergel
commented
Feb 13, 2020
nfelt
approved these changes
Feb 13, 2020
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
LGTM modulo final comments.
davidsoergel
commented
Feb 13, 2020
Member
Author
davidsoergel
left a comment
davidsoergel
left a comment
There was a problem hiding this comment.
Thanks for the review! And sorry for this churn, but the questions about crc32c, and about what to do with empty data or redundant data, inspired me to factor GetBlobMetadata out from WriteBlob. I think this is quite a bit clearer on all fronts.
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.