Skip to content

Convert BaseResponse to wrappers.BaseResponse #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 1 commit into from
Feb 10, 2020
Merged

Convert BaseResponse to wrappers.BaseResponse #3230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tensorboard/backend/empty_path_redirect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def setUp(self):
app = empty_path_redirect.EmptyPathRedirectMiddleware(app)
app = self._lax_strip_foo_middleware(app)
self.app = app
self.server = werkzeug_test.Client(self.app, werkzeug.BaseResponse)
self.server = werkzeug_test.Client(
self.app, werkzeug.wrappers.BaseResponse
Copy link
Contributor

@wchargin wchargin Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK: Confirmed that you don’t need to separately import wrappers and
that it’s available as werkzeug.wrappers by default. LGTM.

)

def _lax_strip_foo_middleware(self, app):
"""Strips a `/foo` prefix if it exists; no-op otherwise."""
Expand Down
4 changes: 3 additions & 1 deletion tensorboard/backend/experiment_id_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ class ExperimentIdMiddlewareTest(tb_test.TestCase):
def setUp(self):
super(ExperimentIdMiddlewareTest, self).setUp()
self.app = experiment_id.ExperimentIdMiddleware(self._echo_app)
self.server = werkzeug_test.Client(self.app, werkzeug.BaseResponse)
self.server = werkzeug_test.Client(
self.app, werkzeug.wrappers.BaseResponse
)

def _echo_app(self, environ, start_response):
# https://www.python.org/dev/peps/pep-0333/#environ-variables
Expand Down
6 changes: 3 additions & 3 deletions tensorboard/backend/path_prefix_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def test_bad_path_prefix_with_trailing_slash(self):

def test_empty_path_prefix(self):
app = path_prefix.PathPrefixMiddleware(self._echo_app, "")
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)

with self.subTest("at empty"):
self._assert_ok(server.get(""), path="", script="")
Expand All @@ -77,7 +77,7 @@ def test_empty_path_prefix(self):

def test_nonempty_path_prefix(self):
app = path_prefix.PathPrefixMiddleware(self._echo_app, "/pfx")
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)

with self.subTest("at root"):
response = server.get("/pfx")
Expand All @@ -103,7 +103,7 @@ def test_composition(self):
app = self._echo_app
app = path_prefix.PathPrefixMiddleware(app, "/bar")
app = path_prefix.PathPrefixMiddleware(app, "/foo")
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)

response = server.get("/foo/bar/baz/quux")
self._assert_ok(response, path="/baz/quux", script="/foo/bar")
Expand Down