[infra] Upgrade FE dependencies #3232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
force-pushed
the
upgrade
branch
5 times, most recently
from
c3a93a6 to
30d0492
Compare
stephanwlee
force-pushed
the
upgrade
branch
3 times, most recently
from
7dfcbd3 to
54ef412
Compare
Contributor
Author
|
The change is ready to be reviewed. Will update the TF cache when I get LGTM. |
stephanwlee
force-pushed
the
upgrade
branch
6 times, most recently
from
f736faf to
043f08b
Compare
nfelt
approved these changes
Apr 21, 2020
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Thanks for taking this on!!
Contributor
There was a problem hiding this comment.
I noticed that removing this was required when I was trying to do this upgrade too. Not blocking but cc @caisq in case this affects the devserver and it needs to be retooled at all to work again after this change.
Notable changes: - Angular 8 -> Angular 9 - zonejs upgrade - ngrx @ 9 - TypeScript @ 3.8.3 - Karma @ 5 - Angular Ivy compiler (ngcc) - Updated rules_nodejs to make it work with Ivy compiler - use node 11 in travis We used [1] as inspiration to our changes. Other notable changes: - window.require is frozen object after require.js upgrade [1]: https://github.com/bazelbuild/rules_nodejs/tree/master/examples/angular
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
Notable changes: Angular 8 -> Angular 9 zonejs upgrade ngrx @ 9 TypeScript @ 3.8.3 Karma @ 5 Angular Ivy compiler (ngcc) Updated rules_nodejs to make it work with Ivy compiler use node 11 in travis We used 1 as inspiration to our changes. Other notable changes: window.require is frozen object after require.js upgrade
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Notable changes: Angular 8 -> Angular 9 zonejs upgrade ngrx @ 9 TypeScript @ 3.8.3 Karma @ 5 Angular Ivy compiler (ngcc) Updated rules_nodejs to make it work with Ivy compiler use node 11 in travis We used 1 as inspiration to our changes. Other notable changes: window.require is frozen object after require.js upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
We used 1 as inspiration to our changes.
Other notable changes:
cc: @caisq