Upgrade min Bazel required and upgrade CI to use 2.1 #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
force-pushed
the
bazel_up
branch
2 times, most recently
from
d198845 to
cac4926
Compare
nfelt
approved these changes
Mar 18, 2020
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
I feel like there was some reason we'd been unsure if we wanted to do this, but I can't remember and maybe it was just my oversight - at any rate, LGTM.
Contributor
Author
|
This is the reason: 49m is too tight for our comfort and I wasn't sure if we should pursue this route. It just has to miraculously pass only once for cache to prolong our life with Travis but that's... not cool. |
Contributor
|
💥 💥 💥 |
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
Bazel is now out of the beta mode (version 0.x). We want to depend on 1+ for better long term support in the future.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Bazel is now out of the beta mode (version 0.x). We want to depend on 1+ for better long term support in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel is now out of the beta mode (version 0.x). We want to depend on
1+ for better long term support in the future.