Skip to content

Add wall_time field to GetOrCreateBlobSequenceRequest #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidsoergel merged 2 commits into from
Feb 14, 2020
Merged

Add wall_time field to GetOrCreateBlobSequenceRequest #3253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6796d3
Add wall_time field to GetOrCreateBlobSequenceRequest
davidsoergel Feb 14, 2020
ab6571f
import timestamp
davidsoergel Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tensorboard/uploader/proto/write_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ syntax = "proto3";

package tensorboard.service;

import "google/protobuf/timestamp.proto";
// TODO(bileschi): write_service.proto imports export_service.proto for the
// definition of Experiment and ExperimentMask. It would be better to excise
// those into one file that both services depend on.
Expand Down Expand Up @@ -277,12 +278,14 @@ message GetOrCreateBlobSequenceRequest {
string tag = 3;
// Step index within the run.
int64 step = 4;
// Timestamp of the creation of this blob sequence.
google.protobuf.Timestamp wall_time = 5;
// The total number of elements expected in the sequence.
// This effectively delares a number of initially empty 'upload slots',
// to be filled with subsequent WriteBlob RPCs.
int64 final_sequence_length = 5;
int64 final_sequence_length = 6;
// Note that metadata.plugin_data.content does not carry the payload.
.tensorboard.SummaryMetadata metadata = 6;
.tensorboard.SummaryMetadata metadata = 7;
}

message GetOrCreateBlobSequenceResponse {
Expand Down