Extract Experiment/ExperimentMask messages into experiment.proto #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
changed the title
stephanwlee
approved these changes
Feb 15, 2020
bileschi
approved these changes
Feb 17, 2020
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
…sorflow#3255) * copy export_service.proto to experiment.proto * Extract Experiment/ExperimentMask messages into experiment.proto
Merged
nfelt
added a commit
that referenced
this pull request
Mar 4, 2020
* copy export_service.proto to experiment.proto * Extract Experiment/ExperimentMask messages into experiment.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a TODO to refactor the
ExperimentandExperimentMaskmessages fromexport_service.protointo a standaloneexperiment.protoso they can be more properly shared across RPC service interfaces.I also updated the comments on fields of the proto to indicate which fields are output-only and cannot be updated directly by RPC clients. (To see the diff, look at only the second commit; I split the file copy out into the first commit since git's move detection can't handle this.)
Will be synchronized with internal changes; see cl/294800076.