uploader: factor test defaults into helpers #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Tests create uploaders and request senders with dependency-injected stubs. As we add more such stubs, the test code bloats and requires broad changes. By centralizing helpers, we can inject defaults that are selectively overridden. Test Plan: Existing tests suffice. wchargin-branch: uploader-test-di-helpers wchargin-source: b5da05e5125eea1248b67841b80a3094b0d9d5a4
davidsoergel
approved these changes
Feb 28, 2020
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
Summary: Tests create uploaders and request senders with dependency-injected stubs. As we add more such stubs, the test code bloats and requires broad changes. By centralizing helpers, we can inject defaults that are selectively overridden. Test Plan: Existing tests suffice. wchargin-branch: uploader-test-di-helpers
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
Summary: Tests create uploaders and request senders with dependency-injected stubs. As we add more such stubs, the test code bloats and requires broad changes. By centralizing helpers, we can inject defaults that are selectively overridden. Test Plan: Existing tests suffice. wchargin-branch: uploader-test-di-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Tests create uploaders and request senders with dependency-injected
stubs. As we add more such stubs, the test code bloats and requires
broad changes. By centralizing helpers, we can inject defaults that are
selectively overridden.
Test Plan:
Existing tests suffice.
wchargin-branch: uploader-test-di-helpers