uploader: export experiment metadata #3308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We now emit an experiments scalar data to `experiment_123/scalars.json` rather than `scalars_123.json`. This generalizes more cleanly to writing multiple files under an experiment’s directory. Test Plan: Unit tests updated. One previous test case can no longer be hit and has thus been removed. wchargin-branch: uploader-export-subdirs wchargin-source: baa128470c061d7d2c0153f6491a1cdf8dd416c5
Summary: When running `tensorboard dev export`, experiment names and descriptions (set with the `update-metadata` subcommand or the `--name` and `--description` flags to `upload`) as well as experiment creation and modification times are now emitted to a new `metadata.json` file in the experiment directory. Test Plan: Unit tests included. Also end-to-end tested against a live server, exporting some experiments with name/description and some without. wchargin-branch: uploader-export-metadata wchargin-source: 7ea3720bd9e84ab9cc006532b53d80393130dba4
wchargin-branch: uploader-export-subdirs wchargin-source: f5009e29cf96dd119b769ad553c5666438f4df99
wchargin-branch: uploader-export-metadata wchargin-source: be420ce7930146aec02da3db4766137d035e824c
bileschi
approved these changes
Feb 29, 2020
tensorboard/uploader/exporter.py
Outdated
| experiment.update_time | ||
| ), | ||
| } | ||
| elif isinstance(experiment, str): |
Collaborator
There was a problem hiding this comment.
Are there actually anymore of these old servers that stream experimen_id instead of experiment proto?
Contributor
Author
There was a problem hiding this comment.
Good question—no, there shouldn’t be. I was considering what to do about
this and thought that it was easier and a bit more conservative to keep
the code as is (this is moved out of _request_experiment_ids) than to
change list_experiments below and drop the old code path. But you’re
right that this has been deployed for a while, so it looks unlikely that
we’ll need to roll the server back. I can go ahead and make that change.
Contributor
Author
There was a problem hiding this comment.
Done as a pre-change in #3310, which indeed simplifies this diff by a
fair amount.
wchargin
changed the base branch from
wchargin-uploader-export-subdirs
to
master
Summary: The `StreamExperiments` RPC response used to send only `experiment_ids`, but now sends `experiments` with additional metadata. This server-side change has been live since late November 2019, so we’re confident that we won’t need to roll it back. Thus, we can drop compatibility for the old code path in new uploader clients. Test Plan: Unit tests updated; verified that the `list` and `export` subcommands still work. wchargin-branch: uploader-require-experiment-metadata wchargin-source: ff0abea38230373d281391f5de90eea4a1f4c01b
wchargin
changed the base branch from
master
to
wchargin-uploader-require-experiment-metadata
wchargin-branch: uploader-export-metadata wchargin-source: 40a50bafa7c90072b0c179e8ddc5d3980394943f # Conflicts: # tensorboard/uploader/exporter.py # tensorboard/uploader/exporter_test.py
wchargin-branch: uploader-export-metadata wchargin-source: 40a50bafa7c90072b0c179e8ddc5d3980394943f
wchargin-branch: uploader-require-experiment-metadata wchargin-source: b53f6cf6c7b49a4ebb34dd3314867bfbca38b4d9
wchargin-branch: uploader-export-metadata wchargin-source: e365339e461182df80bc3ca35c9a3af9c941abe2
ericdnielsen
approved these changes
Mar 2, 2020
wchargin
changed the base branch from
wchargin-uploader-require-experiment-metadata
to
master
wchargin-branch: uploader-export-metadata wchargin-source: 3817d7485290fcd77cc4e2baaacc23676b3cb823 # Conflicts: # tensorboard/uploader/exporter.py # tensorboard/uploader/exporter_test.py
wchargin-branch: uploader-export-metadata wchargin-source: 3817d7485290fcd77cc4e2baaacc23676b3cb823
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
Summary: When running `tensorboard dev export`, experiment names and descriptions (set with the `update-metadata` subcommand or the `--name` and `--description` flags to `upload`) as well as experiment creation and modification times are now emitted to a new `metadata.json` file in the experiment directory. Test Plan: Unit tests included. Also end-to-end tested against a live server, exporting some experiments with name/description and some without. wchargin-branch: uploader-export-metadata
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
Summary: When running `tensorboard dev export`, experiment names and descriptions (set with the `update-metadata` subcommand or the `--name` and `--description` flags to `upload`) as well as experiment creation and modification times are now emitted to a new `metadata.json` file in the experiment directory. Test Plan: Unit tests included. Also end-to-end tested against a live server, exporting some experiments with name/description and some without. wchargin-branch: uploader-export-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When running
tensorboard dev export, experiment names and descriptions(set with the
update-metadatasubcommand or the--nameand--descriptionflags toupload) as well as experiment creation andmodification times are now emitted to a new
metadata.jsonfile in theexperiment directory.
Test Plan:
Unit tests included. Also end-to-end tested against a live server,
exporting some experiments with name/description and some without.
wchargin-branch: uploader-export-metadata