-
Notifications
You must be signed in to change notification settings - Fork 1.7k
TensorBoard 2.2.0 #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorBoard 2.2.0 #3399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a review on #3398 before that PR was closed, so all my draft
comments are there; would you mind reading those so that I don’t have to
copy them all over? Thanks!
Direct link: #3398 (review)
|
Once #3400 merges (unbreaking $ git fetch origin master
$ git push origin origin/master:2.2Then you can rebase your changes onto the new version: Should be no need to delete any branches or force-push to upstream. (I seem to remember that |
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo typo.
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As this is a release PR, you may want to get a second
pair of eyes for a sanity check.
Please remember to rebase and merge (not squash and merge) when
merging this PR.
No description provided.