Skip to content

Conversation

@bileschi
Copy link
Collaborator

No description provided.

@bileschi bileschi requested a review from wchargin March 19, 2020 21:22
Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a review on #3398 before that PR was closed, so all my draft
comments are there; would you mind reading those so that I don’t have to
copy them all over? Thanks!

Direct link: #3398 (review)

@wchargin
Copy link
Contributor

Once #3400 merges (unbreaking tensorboard dev list), we’ll want to
fast-forward the 2.2 branch to include it:

$ git fetch origin master
$ git push origin origin/master:2.2

Then you can rebase your changes onto the new version:

$ git checkout 2.2
$ git rebase origin/2.2
$ git push --force-with-lease bileschi 2.2

Should be no need to delete any branches or force-push to upstream.

(I seem to remember that origin is the name of your remote for this
repo and bileschi is the name of your remote for your fork; if not,
replace accordingly above.)

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo typo.

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As this is a release PR, you may want to get a second
pair of eyes for a sanity check.

Please remember to rebase and merge (not squash and merge) when
merging this PR.

@bileschi bileschi requested a review from stephanwlee March 23, 2020 23:42
@bileschi bileschi merged commit 5702190 into tensorflow:2.2 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants