Skip to content

backend: always provide data provider on context #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchargin merged 4 commits into from
Mar 25, 2020
Merged

backend: always provide data provider on context #3415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
311b3b5
backend: always provide data provider on context
wchargin Mar 23, 2020
2edb5a0
[update diffbase]
wchargin Mar 24, 2020
65656d1
[update patch]
wchargin Mar 24, 2020
131ae5b
[bump ci]
wchargin Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tensorboard/backend/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,9 @@ def standard_tensorboard_wsgi(flags, plugin_loaders, assets_zip_provider):
max_reload_threads=flags.max_reload_threads,
event_file_active_filter=_get_event_file_active_filter(flags),
)
if flags.generic_data != "false":
data_provider = event_data_provider.MultiplexerDataProvider(
multiplexer, flags.logdir or flags.logdir_spec
)
data_provider = event_data_provider.MultiplexerDataProvider(
multiplexer, flags.logdir or flags.logdir_spec
)

if reload_interval >= 0:
# We either reload the multiplexer once when TensorBoard starts up, or we
Expand Down
9 changes: 6 additions & 3 deletions tensorboard/plugins/core/core_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,12 @@ def define_flags(self, parser):
default="auto",
choices=["false", "auto", "true"],
help="""\
[experimental] Whether to use generic data provider infrastructure. The
"auto" option enables this only for dashboards that are considered
stable under the new codepaths. (default: %(default)s)\
[experimental] Hints whether plugins should read from generic data
provider infrastructure. For plugins that support only the legacy
multiplexer APIs or only the generic data APIs, this option has no
effect. The "auto" option enables this only for plugins that are
considered to have stable support for generic data providers. (default:
%(default)s)\
""",
)

Expand Down