Disable auto reload if page is not visible in ng_tensorboard #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
changed the title
stephanwlee
reviewed
Apr 9, 2020
stephanwlee
approved these changes
Apr 10, 2020
| constructor(private store: Store<State>) {} | ||
| constructor( | ||
| private store: Store<State>, | ||
| @Inject(DOCUMENT) private document: Document |
* document is readonly property in ReloaderComponent * fakeDocument is created for each test run
stephanwlee
approved these changes
Apr 13, 2020
| declarations: [ReloaderComponent], | ||
| }).compileComponents(); | ||
| store = TestBed.get(Store); | ||
| fakeDocument = TestBed.get(DOCUMENT); |
Contributor
There was a problem hiding this comment.
just wondering, what happens if you change this to TestBed.get(DOCUMENT) as typeof document?
I want to avoid any where possible.
Contributor
Author
There was a problem hiding this comment.
typeof document doesn't seem to help. I can (and have) made fakeDocument: Document but it requires some slight grossness to override the visibilityState property. That's ok - I think the grossness is outweighed by the better typing.
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
…low#3498) Note that this is the ng_tensorboard version of tensorflow#3483. * Motivation for features / changes Reduce the load on TensorBoard servers by disabling auto reload if the page is not considered visible. * Technical description of changes Do not auto reload if document is not visible according to the Page Visibility API. When page again becomes visible perform an auto reload if one has been missed.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Note that this is the ng_tensorboard version of #3483. * Motivation for features / changes Reduce the load on TensorBoard servers by disabling auto reload if the page is not considered visible. * Technical description of changes Do not auto reload if document is not visible according to the Page Visibility API. When page again becomes visible perform an auto reload if one has been missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is the ng_tensorboard version of #3483.
Motivation for features / changes
Reduce the load on TensorBoard servers by disabling auto reload if the page is not considered visible.
Technical description of changes
Do not auto reload if document is not visible according to the Page
Visibility API. When page again becomes visible perform an auto reload
if one has been missed.
Detailed steps to verify changes work correctly (as executed by you)
Run a local TensorBoard.
Open localhost:6006.
Ensure option "Reload data" is selected and choose a 15s "Reload Period".
Open detached network tab in chrome developer tools.
Watch for several minutes and observe that many network calls are made every 15s.
Open different tab in same window but with chrome developer tools still visible.
Watch for several minutes and observe that no network calls are made.
Switch back to TensorBoard tab and watch as network calls are immediately made and UI reloads graphs.
Continue to watch network tab as it again follows a 15s period for reload network calls.