Skip to content

Catch RuntimeWarning when parsing GraphDef protos. #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidsoergel merged 2 commits into from
Apr 14, 2020
Merged

Catch RuntimeWarning when parsing GraphDef protos. #3508

davidsoergel merged 2 commits into from
Apr 14, 2020

Conversation

@davidsoergel
Copy link
Member

@davidsoergel davidsoergel commented Apr 13, 2020

No description provided.

@davidsoergel davidsoergel requested a review from caisq April 13, 2020 20:43
caisq
caisq requested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@caisq caisq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you add a mock-based test? Mock the FromString() method and let it throw a RuntimeWarning

@davidsoergel
Copy link
Member Author

davidsoergel commented Apr 13, 2020

Added mock-based tests.

caisq
caisq approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidsoergel davidsoergel merged commit fe0455b into master Apr 14, 2020
@davidsoergel davidsoergel deleted the add-empty-graph-test branch April 14, 2020 01:31
@davidsoergel davidsoergel mentioned this pull request Apr 14, 2020
Merged
bileschi pushed a commit to bileschi/tensorboard that referenced this pull request Apr 15, 2020
@davidsoergel @bileschi
Catch RuntimeWarning when parsing GraphDef protos. (tensorflow#3508)
e836e25 
Under certain mysterious circumstances, attempting to parse a malformed serialized `GraphDef` can result in the raising of a `RuntimeWarning` instead of a `DecodeError`.  Here we catch both in order to treat them in the same way.
bileschi pushed a commit that referenced this pull request Apr 15, 2020
@davidsoergel @bileschi
Catch RuntimeWarning when parsing GraphDef protos. (#3508)
e9fb769 
Under certain mysterious circumstances, attempting to parse a malformed serialized `GraphDef` can result in the raising of a `RuntimeWarning` instead of a `DecodeError`.  Here we catch both in order to treat them in the same way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caisq caisq caisq approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidsoergel @caisq @googlebot