uploader_test: check logical equality of protos #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes an oversight in #3507: we can’t assert that the raw bytes are what was expected because the code under test does a proto serialization roundtrip, which is permitted to permute keys. Test Plan: Tests still pass, and this should fix an internal sync error. wchargin-branch: uploader-test-proto-equal
Contributor
Author
Confirmed: http://cl/306474605 (passes on 100/100 runs) |
nfelt
approved these changes
Apr 14, 2020
| data = b"".join(r.data for r in requests) | ||
| self.assertEqual(data, graph_event.graph_def) | ||
| actual_graph_def = graph_pb2.GraphDef.FromString(data) | ||
| self.assertEqual(actual_graph_def, expected_graph_def) |
Contributor
There was a problem hiding this comment.
might as well use assertProtoEquals() for the nicer diff?
Contributor
Author
There was a problem hiding this comment.
I can never remember the assertProtoEquals argument order; thankfully,
a web search turns up familiar faces…
wchargin-branch: uploader-test-proto-equal wchargin-source: 04ec53b1e69857650afdf5437e5e035f8d671623
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Apr 15, 2020
Summary: Fixes an oversight in tensorflow#3507: we can’t assert that the raw bytes are what was expected because the code under test does a proto serialization roundtrip, which is permitted to permute keys. Test Plan: Tests still pass; a test sync shows that internal tests pass now, too. wchargin-branch: uploader-test-proto-equal
bileschi
pushed a commit
that referenced
this pull request
Apr 15, 2020
Summary: Fixes an oversight in #3507: we can’t assert that the raw bytes are what was expected because the code under test does a proto serialization roundtrip, which is permitted to permute keys. Test Plan: Tests still pass; a test sync shows that internal tests pass now, too. wchargin-branch: uploader-test-proto-equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an oversight in #3507: we can’t assert that the raw bytes are what
was expected because the code under test does a proto serialization
roundtrip, which is permitted to permute keys.
Test Plan:
Tests still pass; a test sync shows that internal tests pass now, too.
wchargin-branch: uploader-test-proto-equal