Skip to content

[DebuggerV2] Use more efficient read in /execution/data and /graph_execution/data routes #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caisq merged 3 commits into from
Apr 24, 2020
Merged

[DebuggerV2] Use more efficient read in /execution/data and /graph_execution/data routes #3526

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9911eb
[DebuggerV2] Fix a performance bug in /graph_execution/data
caisq Apr 17, 2020
b0076d1
Address comments
caisq Apr 23, 2020
beafe0a
Merge branch 'master' into dbg2-read-graph-execution-data-perf
caisq Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions tensorboard/plugins/debugger_v2/debug_data_multiplexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,10 @@ def ExecutionData(self, run, begin, end):
runs = self.Runs()
if run not in runs:
return None
# TODO(cais): For scalability, use begin and end kwargs when available in
# `DebugDataReader.execution()`.`
execution_digests = self._reader.executions(digest=True)
end = self._checkBeginEndIndices(begin, end, len(execution_digests))
execution_digests = execution_digests[begin:end]
executions = [
self._reader.read_execution(digest) for digest in execution_digests
]
executions = self._reader.executions(digest=False, begin=begin, end=end)
return {
"begin": begin,
"end": end,
Expand Down Expand Up @@ -366,15 +362,16 @@ def GraphExecutionData(self, run, begin, end, trace_id=None):
"trace_id support for GraphExecutionTraceData is "
"not implemented yet."
)
graph_executions = self._reader.graph_execution_traces(digest=False)
end = self._checkBeginEndIndices(begin, end, len(graph_executions))
digests = self._reader.graph_execution_traces(digest=True)
end = self._checkBeginEndIndices(begin, end, len(digests))
graph_executions = self._reader.graph_execution_traces(
digest=False, begin=begin, end=end
)
return {
"begin": begin,
"end": end,
"num_digests": len(graph_executions),
"graph_executions": [
graph_exec.to_json()
for graph_exec in graph_executions[begin:end]
graph_exec.to_json() for graph_exec in graph_executions
],
}

Expand Down