Refactor tests for _ScalarBatchedRequestSender #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify tests in uploader_test.py that seem to specifically target logic in _ScalarBatchedRequestSender and rewrite them to only use _ScalarBatchedRequestSender and none of the layers above it. This is a useful exercise for the work on _TensorBatchedRequestSender so we can more easily identify which tests need to be written for it. We could also consider refactoring _ScalarBatchedRequestSender to its own file.
bmd3k
changed the title
bmd3k
commented
Apr 20, 2020
| with self.assertRaises(uploader_lib.ExperimentNotFoundError): | ||
| uploader._upload_once() | ||
|
|
||
| def test_upload_preserves_wall_time(self): |
Contributor
Author
There was a problem hiding this comment.
I decided to just plain delete this test. I think it's already covered by test_wall_time_precision().
| self.assertEqual(tag_counts, {"loss": 2}) | ||
|
|
||
| def test_v1_summary_single_value(self): | ||
| def test_expands_multiple_values_in_event(self): |
Contributor
Author
There was a problem hiding this comment.
This is one place where the diff gets confusing.
- test_v1_summary_single_value() has been migrated to ScalarBatchedRequestSenderTest as test_v1_summary().
- test_v1_summary_multiple_value() is kept here but renamed to test_expands_multiple_values_in_event(), which I think is its real value.
bileschi
approved these changes
Apr 22, 2020
Collaborator
bileschi
left a comment
bileschi
left a comment
There was a problem hiding this comment.
Thanks for refactoring this. On the whole these tests are complicated and difficult to follow - i'm sure you agree. I'm not sure I have a good suggestion for how to improve them though.
| with self.assertRaises(uploader_lib.ExperimentNotFoundError): | ||
| uploader._upload_once() | ||
|
|
||
| def test_upload_preserves_wall_time(self): |
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
) Identify tests in uploader_test.py that specifically target logic in _ScalarBatchedRequestSender and rewrite them to only use _ScalarBatchedRequestSender and none of the other layers in uploader.py. This is a useful exercise for the work on _TensorBatchedRequestSender. I was having a difficult time using _ScalarBatchedRequestSender tests to establish a pattern for testing _TensorBatchedRequestSender.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Identify tests in uploader_test.py that specifically target logic in _ScalarBatchedRequestSender and rewrite them to only use _ScalarBatchedRequestSender and none of the other layers in uploader.py. This is a useful exercise for the work on _TensorBatchedRequestSender. I was having a difficult time using _ScalarBatchedRequestSender tests to establish a pattern for testing _TensorBatchedRequestSender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify tests in uploader_test.py that specifically target logic in _ScalarBatchedRequestSender and rewrite them to only use _ScalarBatchedRequestSender and none of the other layers in uploader.py.
This is a useful exercise for the work on _TensorBatchedRequestSender. I was having a difficult time using _ScalarBatchedRequestSender tests to establish a pattern for testing _TensorBatchedRequestSender.