Remove standalone uploader binary target #3538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer make //tensorboard/uploader a binary target. Rename uploader_main to uploader_subcommand. Clean up some BUILD target names by removing "_lib" suffix.
wchargin
approved these changes
Apr 22, 2020
| py_library( | ||
| name = "uploader_main_lib", | ||
| srcs = ["uploader_main.py"], | ||
| name = "uploader_subcommand", |
Contributor
There was a problem hiding this comment.
This new name is much clearer; thanks!
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
Remove standalone uploader binary target that shouldn't be used any longer. No longer make //tensorboard/uploader a binary target. Rename uploader_main to uploader_subcommand. Clean up some BUILD target names by removing "_lib" suffix.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Remove standalone uploader binary target that shouldn't be used any longer. No longer make //tensorboard/uploader a binary target. Rename uploader_main to uploader_subcommand. Clean up some BUILD target names by removing "_lib" suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove standalone uploader binary target that shouldn't be used any longer.
No longer make //tensorboard/uploader a binary target.
Rename uploader_main to uploader_subcommand.
Clean up some BUILD target names by removing "_lib" suffix.
Run unit tests.
Run
bazel run tensorboard/uploader -- listand bazel complains that target no longer exists.Run
bazel run tensorboard -- dev listand bazel succeeds at listing experiments.