Skip to content

[DebuggerV2] Revise and re-enable debugger_v2_plugin_test for Const ops #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caisq merged 2 commits into from
Apr 24, 2020
Merged

[DebuggerV2] Revise and re-enable debugger_v2_plugin_test for Const ops #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4374132
[DebuggerV2] Revise and re-enable debugger_v2_plugin_test for Const ops
caisq Apr 23, 2020
93d40e8
Fix some incorrect indices
caisq Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tensorboard/plugins/debugger_v2/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ py_test(
size = "medium",
srcs = ["debugger_v2_plugin_test.py"],
srcs_version = "PY2AND3",
tags = [
"manual",
"notap", # TODO(b/153722488): Re-enable the test.
],
deps = [
":debug_data_multiplexer",
":debugger_v2_plugin",
Expand Down
49 changes: 29 additions & 20 deletions tensorboard/plugins/debugger_v2/debugger_v2_plugin_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,18 +731,18 @@ def testServeGraphExecutionDigestsPartialRange(self):
run = self._getExactlyOneRun()
response = self.server.get(
_ROUTE_PREFIX
+ "/graph_execution/digests?run=%s&begin=0&end=3" % run
+ "/graph_execution/digests?run=%s&begin=0&end=4" % run
)
self.assertEqual(200, response.status_code)
self.assertEqual(
"application/json", response.headers.get("content-type")
)
data = json.loads(response.get_data())
self.assertEqual(data["begin"], 0)
self.assertEqual(data["end"], 3)
self.assertEqual(data["num_digests"], 186)
self.assertEqual(data["end"], 4)
self.assertEqual(data["num_digests"], 219)
digests = data["graph_execution_digests"]
self.assertLen(digests, 3)
self.assertLen(digests, 4)
self.assertGreater(digests[0]["wall_time"], 0)
self.assertEqual(digests[0]["op_type"], "Placeholder")
self.assertEqual(digests[0]["output_slot"], 0)
Expand All @@ -752,20 +752,29 @@ def testServeGraphExecutionDigestsPartialRange(self):
self.assertGreaterEqual(
digests[1]["wall_time"], digests[0]["wall_time"]
)
self.assertEqual(digests[1]["op_type"], "Placeholder")
self.assertEqual(digests[1]["op_type"], "Const")
self.assertEqual(digests[1]["output_slot"], 0)
self.assertTrue(digests[1]["op_name"])
self.assertNotEqual(digests[1]["op_name"], digests[0]["op_name"])
self.assertTrue(digests[0]["graph_id"])
self.assertTrue(digests[1]["graph_id"])

self.assertGreaterEqual(
digests[2]["wall_time"], digests[1]["wall_time"]
)
# The unstack() function uses the Unpack op under the hood.
self.assertEqual(digests[2]["op_type"], "Unpack")
self.assertEqual(digests[2]["op_type"], "Placeholder")
self.assertEqual(digests[2]["output_slot"], 0)
self.assertTrue(digests[2]["op_name"])
self.assertTrue(digests[0]["graph_id"])
self.assertNotEqual(digests[2]["op_name"], digests[0]["op_name"])
self.assertTrue(digests[2]["graph_id"])

self.assertGreaterEqual(
digests[3]["wall_time"], digests[2]["wall_time"]
)
# The unstack() function uses the Unpack op under the hood.
self.assertEqual(digests[3]["op_type"], "Unpack")
self.assertEqual(digests[3]["output_slot"], 0)
self.assertTrue(digests[3]["op_name"])
self.assertTrue(digests[3]["graph_id"])

def testServeGraphExecutionDigestsImplicitFullRange(self):
_generate_tfdbg_v2_data(self.logdir)
Expand All @@ -779,10 +788,10 @@ def testServeGraphExecutionDigestsImplicitFullRange(self):
)
data = json.loads(response.get_data())
self.assertEqual(data["begin"], 0)
self.assertEqual(data["end"], 186)
self.assertEqual(data["num_digests"], 186)
self.assertEqual(data["end"], 219)
self.assertEqual(data["num_digests"], 219)
digests = data["graph_execution_digests"]
self.assertLen(digests, 186)
self.assertLen(digests, 219)
self.assertGreater(digests[-1]["wall_time"], 0)
# Due to the while loop in the tf.function, the last op executed
# is a Less op.
Expand All @@ -795,18 +804,18 @@ def testServeGraphExecutionDigestOutOfBoundsError(self):
_generate_tfdbg_v2_data(self.logdir)
run = self._getExactlyOneRun()

# begin = 0; end = 200
# begin = 0; end = 300
response = self.server.get(
_ROUTE_PREFIX
+ "/graph_execution/digests?run=%s&begin=0&end=200" % run
+ "/graph_execution/digests?run=%s&begin=0&end=300" % run
)
self.assertEqual(response.status_code, 400)
self.assertEqual(
"application/json", response.headers.get("content-type")
)
self.assertEqual(
json.loads(response.get_data()),
{"error": "Invalid argument: end index (200) out of bounds (186)"},
{"error": "Invalid argument: end index (300) out of bounds (219)"},
)

# begin = -1; end = 2
Expand Down Expand Up @@ -903,7 +912,7 @@ def testServeMultipleGraphExecutionDataObjects(self):
self.assertGreaterEqual(len(graph_exec["graph_ids"]), 1)
self.assertEqual(graph_exec["graph_ids"][-1], graph_exec["graph_id"])
self.assertEqual(
graph_exec["debug_tensor_value"], [2.0, 4.0, 0.0, 0.0, 0.0]
graph_exec["debug_tensor_value"], [3.0, 4.0, 0.0, 0.0, 0.0]
)
self.assertEndsWith(graph_exec["device_name"], _DEFAULT_DEVICE_SUFFIX)

Expand All @@ -916,7 +925,7 @@ def testServeMultipleGraphExecutionDataObjects(self):
self.assertGreaterEqual(len(graph_exec["graph_ids"]), 1)
self.assertEqual(graph_exec["graph_ids"][-1], graph_exec["graph_id"])
self.assertEqual(
graph_exec["debug_tensor_value"], [3.0, 1.0, 0.0, 0.0, 0.0]
graph_exec["debug_tensor_value"], [4.0, 1.0, 0.0, 0.0, 0.0]
)
self.assertEndsWith(graph_exec["device_name"], _DEFAULT_DEVICE_SUFFIX)

Expand All @@ -926,17 +935,17 @@ def testServeGraphExecutionDataObjectsOutOfBoundsError(self):

# _generate_tfdbg_v2_data() generates exactly 186 graph-execution
# traces.
# begin = 0; end = 187
# begin = 0; end = 220
response = self.server.get(
_ROUTE_PREFIX + "/graph_execution/data?run=%s&begin=0&end=187" % run
_ROUTE_PREFIX + "/graph_execution/data?run=%s&begin=0&end=220" % run
)
self.assertEqual(response.status_code, 400)
self.assertEqual(
"application/json", response.headers.get("content-type")
)
self.assertEqual(
json.loads(response.get_data()),
{"error": "Invalid argument: end index (187) out of bounds (186)"},
{"error": "Invalid argument: end index (220) out of bounds (219)"},
)

# begin = -1; end = 2
Expand Down