cleanup: fix undeclared and incorrect BUILD deps #3641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated mechanically by the following (note that for graphs, we special case and copy from graphs_plugin_test_lib rather than graphs_plugin_test): buildozer 'copy deps audio_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/audio:audio_plugin_notf_test buildozer 'copy deps custom_scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/custom_scalar:custom_scalars_plugin_notf_test buildozer 'copy deps distributions_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/distribution:distributions_plugin_notf_test buildozer 'copy deps graphs_plugin_test_lib' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/graph:graphs_plugin_notf_test buildozer 'copy deps histograms_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/histogram:histograms_plugin_notf_test buildozer 'copy deps images_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/image:images_plugin_notf_test buildozer 'copy deps pr_curves_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/pr_curve:pr_curves_plugin_notf_test buildozer 'copy deps projector_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/projector:projector_plugin_notf_test buildozer 'copy deps scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/scalar:scalars_plugin_notf_test buildozer 'copy deps text_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/text:text_plugin_notf_test
stephanwlee
approved these changes
May 16, 2020
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
* update `*_plugin_notf_test` target deps to match `*_plugin_test` deps Generated mechanically by the following (note that for graphs, we special case and copy from graphs_plugin_test_lib rather than graphs_plugin_test): ``` buildozer 'copy deps audio_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/audio:audio_plugin_notf_test buildozer 'copy deps custom_scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/custom_scalar:custom_scalars_plugin_notf_test buildozer 'copy deps distributions_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/distribution:distributions_plugin_notf_test buildozer 'copy deps graphs_plugin_test_lib' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/graph:graphs_plugin_notf_test buildozer 'copy deps histograms_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/histogram:histograms_plugin_notf_test buildozer 'copy deps images_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/image:images_plugin_notf_test buildozer 'copy deps pr_curves_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/pr_curve:pr_curves_plugin_notf_test buildozer 'copy deps projector_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/projector:projector_plugin_notf_test buildozer 'copy deps scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/scalar:scalars_plugin_notf_test buildozer 'copy deps text_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/text:text_plugin_notf_test ``` * add missing deps inherited transitively through application
This was referenced May 19, 2020
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
* update `*_plugin_notf_test` target deps to match `*_plugin_test` deps Generated mechanically by the following (note that for graphs, we special case and copy from graphs_plugin_test_lib rather than graphs_plugin_test): ``` buildozer 'copy deps audio_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/audio:audio_plugin_notf_test buildozer 'copy deps custom_scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/custom_scalar:custom_scalars_plugin_notf_test buildozer 'copy deps distributions_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/distribution:distributions_plugin_notf_test buildozer 'copy deps graphs_plugin_test_lib' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/graph:graphs_plugin_notf_test buildozer 'copy deps histograms_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/histogram:histograms_plugin_notf_test buildozer 'copy deps images_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/image:images_plugin_notf_test buildozer 'copy deps pr_curves_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/pr_curve:pr_curves_plugin_notf_test buildozer 'copy deps projector_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/projector:projector_plugin_notf_test buildozer 'copy deps scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/scalar:scalars_plugin_notf_test buildozer 'copy deps text_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/text:text_plugin_notf_test ``` * add missing deps inherited transitively through application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues with inaccurate BUILD deps as pre-work for a coming change to split up application.py. A number of the changes are to
*_plugin_notf_testtargets that have drifted out of sync with their non-no-TF equivalents, so I've factored out the first commit which just mechanically fixes all of those targets in a first pass so that they use the same deps as*_plugin_test.The second commit adds explicit dependencies that were being silently inherited through
//tensorboard/backend:application, typically related to event multiplexer or event processing.