[oss-timeseries] migrate metrics backend #4168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
approved these changes
Sep 17, 2020
Contributor
wchargin
left a comment
wchargin
left a comment
There was a problem hiding this comment.
Approving based on your justification and because tests pass (and
verified that the new tests are being run). Only skimmed the diff.
| def _build_combined_description(descriptions, description_to_runs): | ||
| """Creates a single description from a set of descriptions. | ||
|
|
||
| Descriptions may be composites when a single tag has different descriptions |
Contributor
There was a problem hiding this comment.
All the docstring formatting is borked. Could you please run
docformatter once? I did this when first adding Black in #2967 and it
worked like a charm.
Contributor
Author
There was a problem hiding this comment.
Done. It did work like a charm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the plugin backend for Time Series to OSS, originally internal.
Googlers, this PR is made by copying changes as is from
cl/331838160, removing unused imports, and running the
blackformatter.
See that CL for manual changes introduced.