rust: run libc build script
#4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When setting up the transitive dep on `libc` in #4316, I had originally passed `--cfg=libc_align`, because that fixed the build for me and on CI, and I couldn’t figure out the right cross-platform fix. But @faern [helpfully points out that we just need to run the build script][1], which detects the OS and Rust compiler version to determine the appropriate flags. Bazel `rules_rust` can handle this, if we just ask. (I should have followed my own `DEVELOPMENT.md` suggestions!) [1]: rust-lang/socket2#130 (comment) Test Plan: It still builds—`bazel build @raze__libc__0_2_80//:libc`—and the demo server still works and accepts requests following #4318’s test plan. wchargin-branch: rust-libc-gen-buildrs wchargin-source: 4ddff8d0b822585a9e84c7a24c4577b97b9c5d6a
wchargin
added
dependencies
stephanwlee
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When setting up the transitive dep on
libcin #4316, I had originallypassed
--cfg=libc_align, because that fixed the build for me and onCI, and I couldn’t figure out the right cross-platform fix. But @faern
helpfully points out that we just need to run the build script,
which detects the OS and Rust compiler version to determine the
appropriate flags. Bazel
rules_rustcan handle this, if we just ask.(I should have followed my own
DEVELOPMENT.mdsuggestions!)Test Plan:
It still builds—
bazel build @raze__libc__0_2_80//:libc—and the demoserver still works and accepts requests following #4318’s test plan.
wchargin-branch: rust-libc-gen-buildrs