mesh: fix is_active without multiplexer
#4426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The mesh plugin’s `is_active` method had a hard dependency on the event multiplexer, which is not always available, as `TBContext` documents. In fact, the entire `is_active` method can just be `return False`, since TensorBoard core will treat the `"mesh"` plugin as active when `"mesh"` data is available, and that’s all that it was checking, anyway. Test Plan: The mesh plugin appears active in a logdir with mesh data and inactive without it, and when launching with `--load_fast` (and thus no multiplexer) there’s no longer any log spam about “Plugin listing: is_active() for mesh failed”. (Cherry-pick #4411 for --load_fast.) wchargin-branch: mesh-isactive wchargin-source: fa80676693f66b52489b19f8041adb62f62660de
wchargin-branch: mesh-isactive wchargin-source: 26527da49754e9166d7f812092c873d35a2b004b
stephanwlee
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The mesh plugin’s
is_activemethod had a hard dependency on the eventmultiplexer, which is not always available, as
TBContextdocuments.In fact, the entire
is_activemethod can just bereturn False, sinceTensorBoard core will treat the
"mesh"plugin as active when"mesh"data is available, and that’s all that it was checking, anyway.
Test Plan:
The mesh plugin appears active in a logdir with mesh data and inactive
in one without it, and when launching with
--load_fast(and thus nomultiplexer) there’s no longer any log spam about “Plugin listing:
is_active() for mesh failed”.
wchargin-branch: mesh-isactive