py3: remove argparse_util helper
#4493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In #2793, we added a helper to ensure that you can run `tensorboard` either with or without an explicit subcommand. This works by default in Python 3; the helper was only needed for Python 2. Thus, we remove it. Part of #4488. Test Plan: The test plan from #2793 still passes. Instead of patching in a `demo` subcommand, you can now use `tensorboard dev list [--json]`. wchargin-branch: py3-no-argparseutil wchargin-source: 0f5517b1b09e4fae5158096d55cf8b6247b2e2e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #2793, we added a helper to ensure that you can run
tensorboardeither with or without an explicit subcommand. This works by default in
Python 3; the helper was only needed for Python 2. Thus, we remove it.
Part of #4488.
Test Plan:
The test plan from #2793 still passes. Instead of patching in a
demosubcommand, you can now use
tensorboard dev list [--json].wchargin-branch: py3-no-argparseutil