Revert "projector: fix RunPaths result aliasing (#4479)"
#4506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Some Google-internal, non-TensorBoard code depends on the projector and monkey patches out its internals in a way that is not compatible with the changes in #4479. This is clearly not ideal and should probably be fixed downstream, but pending investigation we revert #4479 to unbreak. This reverts commit 638014e. Test Plan: Test sync at this tree passes all tests. wchargin-branch: projector-revert-4479 wchargin-source: b0d20a84c557976e8c84c061a5a9dec742c11e7c
bmd3k
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some Google-internal, non-TensorBoard code depends on the projector and
monkey patches out its internals in a way that is not compatible with
the changes in #4479. This is clearly not ideal and should probably be
fixed downstream, but pending investigation we revert #4479 to unbreak.
This reverts commit 638014e.
Test Plan:
Test sync at this tree passes all tests.
wchargin-branch: projector-revert-4479