rust: run Clippy on tests and fix existing errors #4512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We run Clippy to catch common errors, but by default Clippy only runs on non-test code. We noticed this in #4487, when Clippy would have caught a real error (test doing nothing due to `unit_cmp`). This patch adds the `--tests` flag to our Clippy invocation and fixes all existing warnings. Test Plan: The first draft of this PR will include only the workflow change, and so should fail… wchargin-branch: rust-clippy-tests wchargin-source: 3be9bc4b9c2084a9f9dda2b0082227f061989811
wchargin-branch: rust-clippy-tests wchargin-source: 48d4d66fb8ad1a7450fa3036379fedcc4191e0e1
bileschi
reviewed
Jan 4, 2021
tensorboard/data/server/lib.rs
Outdated
| pub fn zero(x: f32) -> bool { | ||
| x == 0.0 | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
What is the purpose of this zero function?
Contributor
Author
There was a problem hiding this comment.
Oops, unintentional; thanks for catching. (I added this while playing
around with different approaches to the float_cmp lint: I was trying
to set #![cfg_attr(test, allow(clippy::float_cmp))] to permit
floating-point comparisons in test code, but it didn’t do exactly what
I’d wanted.)
bileschi
approved these changes
Jan 4, 2021
Collaborator
bileschi
left a comment
bileschi
left a comment
There was a problem hiding this comment.
Approved. Confused about the zero impl. Don't see anything in the lint about problems with lib.rs either?
wchargin-branch: rust-clippy-tests wchargin-source: 1c901870ac667625b5b2332c8bf65492c0457e92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We run Clippy to catch common errors, but by default Clippy only runs on
non-test code. We noticed this in #4487, when Clippy would have caught a
real error (test doing nothing due to
unit_cmp). This patch adds the--testsflag to our Clippy invocation and fixes all existing warnings.Test Plan:
The first draft of this PR included only the workflow change, and thus
properly failed on CI. Once the fixes were included, CI passed.
wchargin-branch: rust-clippy-tests