py3: run whitespace_hygiene_test.py in Python 3
#4514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Noticed in the original, failed CI run of #4507 that this script ran in Python 2, since its `print()` caused an extra `()` to be printed (since we turned off `print_function` in #4503. This happens because its shebang specifies the system’s default `python` and the CI job that invokes it doesn’t set up a Python 3 virtualenv. The script still works, since it’s effectively bicompatible, but for consistency we should still make sure that everything runs on Python 3 only (else the tasks in #4488 are not necessarily sound). Test Plan: `git grep bin/python` only matches this line. wchargin-branch: py3-whitespace-test wchargin-source: 2da3c38930b54c3881c39d2813a8686989f9430c
nfelt
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed in the original, failed CI run of #4507 that this script ran in
Python 2, since its
print()caused an extra()to be printed (sincewe turned off
print_functionin #4503). This happens because itsshebang specifies the system’s default
pythonand the CI job thatinvokes it doesn’t set up a Python 3 virtualenv. The script still works,
since it’s effectively bicompatible, but for consistency we should still
make sure that everything runs on Python 3 only (else the tasks in #4488
are not necessarily sound).
Test Plan:
git grep bin/pythononly matches this line, and we have no uses of/usr/bin/env python, either.wchargin-branch: py3-whitespace-test