py3: use html.escape unconditionally
#4515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `html.escape` function superseded `cgi.escape` in Python 3.2, prior to which the `html` module did not exist. We now unconditionally import `html`, without falling back to `cgi`. Part of #4488. Test Plan: Tested the Pip package in Jupyter. When rebased on top of #4507, which removes the `unittest.mock` backport, a `git grep -A1 '^try:'` shows that the remaining top-level conditional statements are okay: a bunch of TensorFlow compatibility incantations for summaries, and one conditional import of `botocore`. wchargin-branch: py3-html-escape wchargin-source: 2f17731ec538eb904d673edccf63310afa585ef3
stephanwlee
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
html.escapefunction supersededcgi.escapein Python 3.2, priorto which the
htmlmodule did not exist. We now unconditionally importhtml, without falling back tocgi.Part of #4488.
Test Plan:
Tested the Pip package in Jupyter. When rebased on top of #4507, which
removes the
unittest.mockbackport, agit grep -A1 '^try:'showsthat the remaining top-level conditional statements are okay: a bunch of
TensorFlow compatibility incantations for summaries, and one conditional
import of
botocore.wchargin-branch: py3-html-escape